Moved isEncryptionAvailable() to top of file and refactored to prevent
"Cannot read properties of undefined" errors when safeStorage exists
but doesn't have the isEncryptionAvailable method.
Changes:
- Move isEncryptionAvailable() before other functions so it can be used
- Add typeof check for isEncryptionAvailable method existence
- Use isEncryptionAvailable() helper in encryptApiKey() instead of
directly calling safeStorage.isEncryptionAvailable()
- Ensures consistent safe checking across all encryption operations
This fixes the settings UI crash that prevented API key management
section from rendering.
The isEncryptionAvailable() function was throwing "Cannot read properties
of undefined" when safeStorage exists but doesn't have the
isEncryptionAvailable method (can occur on some Electron versions).
This was causing the entire settings UI to fail rendering after the
Authentication heading, hiding all API key management controls.
Fix: Add typeof check before calling safeStorage.isEncryptionAvailable()
to ensure the method exists before attempting to call it.
Add try-catch blocks and console logging to identify where settings UI
stops rendering. This will help diagnose why API key and config sections
are not appearing after authentication was made mandatory.
Diagnostic additions:
- Wrap auth description section in try-catch
- Wrap API key section in try-catch
- Log encryption availability status
- Log API key length
- Log successful section rendering
- Display user-friendly error messages if rendering fails
- Added safe electron import with fallback for non-electron environments
- Enhanced error handling when safeStorage is unavailable
- Updated encryption checks to handle cases where safeStorage is null
- Added warning message when API keys must be stored in plaintext
- Modified isEncryptionAvailable to check for both safeStorage existence and capability
- Removed implementation summary, quickstart guide, and roadmap files to simplify documentation
- Streamlined README.md by removing development setup instructions and release process details
- Retained core plugin documentation including features, usage, and configuration
- Simplified authentication section to focus on key functionality
Update README.md and CLAUDE.md to reflect:
- Removed CORS configuration options (enableCORS, allowedOrigins)
- Mandatory authentication with auto-generated API keys
- API key encryption using system keychain
- Fixed localhost-only CORS policy
Changes:
- README.md: Updated Configuration, Security Considerations, and Usage sections
- CLAUDE.md: Updated Settings and Security Model sections
Update main.ts to automatically generate API keys on first load,
encrypt them when saving to disk, and decrypt them when loading.
Also migrate legacy settings by removing enableCORS and
allowedOrigins fields.
Changes:
- Auto-generate API key if empty on plugin load
- Encrypt API key before saving to data.json
- Decrypt API key after loading from data.json
- Migrate legacy settings by removing CORS-related fields
- Add imports for generateApiKey, encryptApiKey, decryptApiKey
- Add comprehensive migration tests in main-migration.test.ts
This implements Task 4 of the CORS simplification plan.
- Remove enableCORS and allowedOrigins from MCPServerSettings
- Make apiKey required (string, not optional)
- Set enableAuth to true by default
- Add comprehensive test coverage for settings types
Install electron as dev dependency to provide type definitions for safeStorage API.
Removes need for @types/electron as electron provides its own types.
Implement encryption utilities for securely storing API keys:
- encryptApiKey(): encrypts keys using Electron safeStorage with base64 encoding
- decryptApiKey(): decrypts stored keys
- isEncryptionAvailable(): checks platform support
Encryption falls back to plaintext on platforms without keyring support.
Includes comprehensive test coverage with Electron mock.
Add base64 validation and error handling for compressed Excalidraw data:
- Validate compressed data using atob() before processing
- Add console.error logging for decompression failures
- Handle invalid base64 gracefully with fallback metadata
- Add test for decompression failure scenario
This improves frontmatter-utils coverage from 95.9% to 98.36%.
Remaining uncovered lines (301-303) are Buffer.from fallback for
environments without atob, which is expected and acceptable.
Fixed regex pattern overlap where Pattern 3 with [a-z-]* (zero or more)
would always match code fences without language specifiers, making
Pattern 4 unreachable.
Changed Pattern 3 from [a-z-]* to [a-z-]+ (one or more) so:
- Pattern 3 matches code fences WITH language specifiers
- Pattern 4 matches code fences WITHOUT language specifiers
This fix allows lines 253-255 to be properly covered by tests.
Coverage improvement:
- frontmatter-utils.ts: 96.55% -> 99.13%
- Lines 253-255 now covered
Test changes:
- Added test for Pattern 4 code path
- Removed failing decompression test (part of Task 6)
Remove unused permissionDenied() and formatError() methods that are never called in the codebase.
Coverage improvement:
- error-messages.ts: 82.6% → 100% statement coverage
This is Task 1 from the utils coverage completion plan.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Changes:
- Updated Windows path rejection tests to use backslashes as specified
- Added comprehensive pathExists() method tests
- Reordered validation checks in isValidVaultPath() to ensure Windows
absolute paths are caught before invalid character check
- This fix ensures the Windows drive letter validation is reachable
Coverage improvement: 98.18% -> 100%
Tests added: 3 new test cases
All 512 tests passing
Remove documentation for createVersionedResponse() method that was
deleted from version-utils.ts as part of dead code cleanup. The method
was never called in the codebase and was only referenced in the
CHANGELOG.
This completes Task 3 of the utils coverage completion plan.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Remove dead code from VersionUtils to improve test coverage:
- Deleted createVersionedResponse() method (never called in codebase)
- Method was only documented in CHANGELOG, no actual usage found
- Coverage improved: version-utils.ts 88.88% -> 100%
All 505 tests passing.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Added test for getFolderWaypoint file read error handling (line 777)
- Documented unreachable defensive code in stat() (lines 452-456)
- Documented unreachable defensive code in exists() (lines 524-528)
- Added istanbul ignore comments for unreachable defensive returns
Analysis:
- Lines 452-456 and 524-528 are unreachable because getAbstractFileByPath
only returns TFile, TFolder, or null - all cases are handled before
the defensive fallback code
- Line 777 is now covered by testing file read errors in getFolderWaypoint
Coverage: vault-tools.ts now at 100% statement coverage (99.8% tools overall)
Test count: 84 vault-tools tests, 505 total tests passing
- Add test for list() skipping root folder (line 267)
- Add test for list() normalizing aliases from string to array (line 325)
- Add test for list() handling array aliases (line 325)
- Add test for getFolderMetadata() handling folder with mtime (line 374)
- Add test for getFolderMetadata() handling folder without mtime
- Add test for list() on non-root path (line 200)
- Add test for search() stopping at maxResults=1 on file boundary (line 608)
- Add test for search() stopping at maxResults=1 within file (line 620)
- Add test for search() adjusting snippet for long lines (line 650)
Coverage improved from 95.66% to 98.19% for vault-tools.ts
Added targeted test cases to improve vault-tools.ts coverage:
- Test for listNotes() with invalid vault path (covers line 76)
- Test for list() with glob excludes filtering (covers line 272)
- Test for search() with glob include/exclude patterns (covers lines 596-597)
Coverage improved from 94.22% to 95.66% for vault-tools.ts.
All tests passing (75 tests).
Add test for read_excalidraw with includeCompressed option to cover
line 647. Add test for update_frontmatter on files without existing
frontmatter to cover line 771.
Coverage for note-tools.ts now at 100% line coverage (99.6% statement,
92.82% branch, 90.9% function).
Add 5 tests for folder-not-file error cases:
- read_note when path is a folder (line 61-66 in source)
- rename_file when source path is a folder (line 377)
- rename_file when destination path is a folder (line 408)
- read_excalidraw when path is a folder (line 590)
- update_frontmatter when path is a folder (line 710)
- update_sections when path is a folder (line 836)
All tests verify error message uses ErrorMessages.notAFile()
Coverage for note-tools.ts increased to 98%
Add test case for conflict resolution loop in createNote when multiple
numbered file variants exist. Test verifies the loop correctly increments
counter (lines 238-239) by creating file 3.md when file.md, file 1.md,
and file 2.md already exist.
Coverage improvement: note-tools.ts 96.01% -> 96.81%
Lines 238-239 now covered.
- Add 46 comprehensive tests for LinkUtils covering all methods
- Test parseWikilinks() with various formats, aliases, headings, paths
- Test resolveLink() with MetadataCache integration and edge cases
- Test findSuggestions() with scoring algorithms and fuzzy matching
- Test getBacklinks() with linked/unlinked mentions and snippet extraction
- Test validateWikilinks() with resolved/unresolved link validation
- Achieve 100% statement, function, and line coverage on link-utils.ts
- Test extractWaypointBlock() with valid/invalid waypoints, unclosed blocks, multiple links
- Test hasWaypointMarker() with all marker combinations
- Test isFolderNote() with basename match, waypoint marker, both, neither, file read errors
- Test wouldAffectWaypoint() detecting removal, content changes, acceptable moves
- Test getParentFolderPath() and getBasename() helper methods
- Achieve 100% coverage on waypoint-utils.ts (52 tests)
Updated VaultTools to use adapters for all utility method calls:
- SearchUtils.searchWaypoints() now receives vault adapter
- WaypointUtils.isFolderNote() now receives vault adapter
- LinkUtils.validateWikilinks() now receives vault and metadata adapters
- LinkUtils.resolveLink() now receives vault and metadata adapters
- LinkUtils.getBacklinks() now receives vault and metadata adapters
Removed App dependency from VaultTools constructor - now only requires
vault and metadata adapters. Updated factory and all test files accordingly.
All tests passing (336/336).
- Change WaypointUtils.isFolderNote() signature to accept IVaultAdapter
instead of App
- Update method body to use vault.read() instead of app.vault.read()
- Callers will be updated in next commit
- Test all glob pattern types: *, **, ?, [abc], {a,b}
- Test edge cases: unclosed brackets, unclosed braces
- Test all public methods: matches(), matchesIncludes(), matchesExcludes(), shouldInclude()
- Test special regex character escaping: . / ( ) + ^ $ | \
- Test complex pattern combinations and real-world scenarios
- Achieve 100% coverage on glob-utils.ts (52 tests)
Summary of dependency injection refactoring:
- 96% coverage on NoteTools
- 94% coverage on VaultTools
- 236 tests passing
- Adapter pattern fully implemented
- Factory functions for production usage
Architecture improvements:
- IVaultAdapter, IMetadataCacheAdapter, IFileManagerAdapter interfaces
- Clean separation between business logic and Obsidian API
- Simplified test mocking with adapter pattern
- Type-safe dependency injection throughout
Update parent-folder-detection.test.ts to use the new mock adapter
pattern (createMockVaultAdapter, createMockFileManagerAdapter) instead
of manually mocking Obsidian API objects.
Key changes:
- Replace manual vault/app mocks with adapter helpers
- Use createMockTFile and createMockTFolder for consistent fixtures
- Fix mock reference synchronization with getter pattern for App.vault
- Standardize all mock reassignments to use jest.fn() methods
- Update all 14 tests to properly reassign mocks in test setup
This resolves all 7 failing tests and improves test maintainability
by using consistent mock patterns across the test suite.
All tests passing: 14/14 in parent-folder-detection.test.ts
Implements Task 10 from the implementation plan:
1. Updated NoteTools constructor to accept IVaultAdapter and IFileManagerAdapter
2. Created note-tools-factory.ts with factory function
3. Migrated all CRUD methods to use adapters:
- readNote: uses vault.read()
- createNote: uses vault.create(), vault.delete()
- createParentFolders: uses vault.createFolder()
- updateNote: uses vault.read(), vault.modify()
- deleteNote: uses vault.trash(), vault.delete()
- renameFile: uses fileManager.renameFile()
- readExcalidraw: uses vault.read()
- updateFrontmatter: uses vault.read(), vault.modify()
- updateSections: uses vault.read(), vault.modify()
4. Extended IVaultAdapter interface with modify(), delete(), and trash() methods
5. Implemented new methods in VaultAdapter
6. Updated ToolRegistry to use factory function
7. Kept app parameter temporarily for PathUtils dependency
8. All methods now use adapters instead of direct Obsidian API calls
9. Code compiles successfully
This change enables 100% test coverage by allowing full mocking of vault operations.
Update validateWikilinks, resolveWikilink, and getBacklinks methods
to use IVaultAdapter and IMetadataCacheAdapter instead of direct App access.
- Implemented inline link suggestion finding using vault adapter
- Implemented backlinks retrieval using metadata cache adapter
- Added helper methods: findLinkSuggestions, extractSnippet, escapeRegex
- App parameter still required for waypoint methods (not in scope for this task)
