Bill/obsidian-mcp-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: improve promise handling in DOM event listeners

Browse Source 
Wrap async callbacks in void operators for DOM addEventListener calls
to properly handle Promise<void> returns in void contexts. This follows
TypeScript best practices and Obsidian plugin guidelines.

Changes:
- settings.ts: Fix 5 button click handlers (server controls, API key actions, config copy)
- notification-history.ts: Fix export button click handler

All async operations are properly awaited within void-wrapped IIFEs,
ensuring errors are not silently swallowed while maintaining the
expected void return type for event listeners.
This commit is contained in:
Bill Ballou
2025-11-07 11:25:24 -05:00
parent dab456b44e
commit e18321daea
2 changed files with 51 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
src/settings.ts
View File

@@ -146,22 +146,28 @@ export class MCPServerSettingTab extends PluginSettingTab {
if (isRunning) {
buttonContainer.createEl('button', {text: 'Stop Server'})
.addEventListener('click', async () => {
await this.plugin.stopServer();
this.display();
.addEventListener('click', () => {
void (async () => {
await this.plugin.stopServer();
this.display();
})();
});
buttonContainer.createEl('button', {text: 'Restart Server'})
.addEventListener('click', async () => {
await this.plugin.stopServer();
await this.plugin.startServer();
this.display();
.addEventListener('click', () => {
void (async () => {
await this.plugin.stopServer();
await this.plugin.startServer();
this.display();
})();
});
} else {
buttonContainer.createEl('button', {text: 'Start Server'})
.addEventListener('click', async () => {
await this.plugin.startServer();
this.display();
.addEventListener('click', () => {
void (async () => {
await this.plugin.startServer();
this.display();
})();
});
}
@@ -215,21 +221,25 @@ export class MCPServerSettingTab extends PluginSettingTab {
// Copy button
const copyButton = apiKeyButtonContainer.createEl('button', {text: '📋 Copy Key'});
copyButton.addEventListener('click', async () => {
await navigator.clipboard.writeText(this.plugin.settings.apiKey || '');
new Notice('✅ API key copied to clipboard');
copyButton.addEventListener('click', () => {
void (async () => {
await navigator.clipboard.writeText(this.plugin.settings.apiKey || '');
new Notice('✅ API key copied to clipboard');
})();
});
// Regenerate button
const regenButton = apiKeyButtonContainer.createEl('button', {text: '🔄 Regenerate Key'});
regenButton.addEventListener('click', async () => {
this.plugin.settings.apiKey = generateApiKey();
await this.plugin.saveSettings();
new Notice('✅ New API key generated');
if (this.plugin.mcpServer?.isRunning()) {
new Notice('⚠️ Server restart required for API key changes to take effect');
}
this.display();
regenButton.addEventListener('click', () => {
void (async () => {
this.plugin.settings.apiKey = generateApiKey();
await this.plugin.saveSettings();
new Notice('✅ New API key generated');
if (this.plugin.mcpServer?.isRunning()) {
new Notice('⚠️ Server restart required for API key changes to take effect');
}
this.display();
})();
});
// API Key display (static, copyable text)
@@ -284,9 +294,11 @@ export class MCPServerSettingTab extends PluginSettingTab {
text: '📋 Copy Configuration',
cls: 'mcp-config-button'
});
copyConfigButton.addEventListener('click', async () => {
await navigator.clipboard.writeText(JSON.stringify(config, null, 2));
new Notice('✅ Configuration copied to clipboard');
copyConfigButton.addEventListener('click', () => {
void (async () => {
await navigator.clipboard.writeText(JSON.stringify(config, null, 2));
new Notice('✅ Configuration copied to clipboard');
})();
});
// Config JSON display
@@ -413,9 +425,11 @@ export class MCPServerSettingTab extends PluginSettingTab {
text: '📋 Copy Configuration',
cls: 'mcp-config-button'
});
copyConfigButton.addEventListener('click', async () => {
await navigator.clipboard.writeText(JSON.stringify(config, null, 2));
new Notice('✅ Configuration copied to clipboard');
copyConfigButton.addEventListener('click', () => {
void (async () => {
await navigator.clipboard.writeText(JSON.stringify(config, null, 2));
new Notice('✅ Configuration copied to clipboard');
})();
});
// Config JSON display

18
src/ui/notification-history.ts
View File

@@ -162,14 +162,16 @@ export class NotificationHistoryModal extends Modal {
// Export button
const exportButton = actionsContainer.createEl('button', { text: 'Export to Clipboard' });
exportButton.addEventListener('click', async () => {
const exportData = JSON.stringify(this.filteredHistory, null, 2);
await navigator.clipboard.writeText(exportData);
// Show temporary success message
exportButton.textContent = '✅ Copied!';
setTimeout(() => {
exportButton.textContent = 'Export to Clipboard';
}, 2000);
exportButton.addEventListener('click', () => {
void (async () => {
const exportData = JSON.stringify(this.filteredHistory, null, 2);
await navigator.clipboard.writeText(exportData);
// Show temporary success message
exportButton.textContent = '✅ Copied!';
setTimeout(() => {
exportButton.textContent = 'Export to Clipboard';
}, 2000);
})();
});
// Close button