Files
AI-Trader/tests/unit/test_dev_database.py
Bill a9dd346b35 fix: correct test suite failures for async price download
Fixed two test issues:
1. test_config_override.py: Updated hardcoded worktree path from config-override-system to async-price-download
2. test_dev_database.py: Added thread-local connection cleanup to prevent SQLite file locking issues

All tests now pass:
- Unit tests: 200 tests
- Integration tests: 47 tests (46 passed, 1 skipped)
- E2E tests: 3 tests
- Total: 250 tests collected
2025-11-02 07:00:19 -05:00

123 lines
3.9 KiB
Python

import os
import pytest
from pathlib import Path
from api.database import initialize_dev_database, cleanup_dev_database
@pytest.fixture
def clean_env():
"""Fixture to ensure clean environment variables for each test"""
original_preserve = os.environ.get("PRESERVE_DEV_DATA")
os.environ.pop("PRESERVE_DEV_DATA", None)
yield
# Restore original state
if original_preserve:
os.environ["PRESERVE_DEV_DATA"] = original_preserve
else:
os.environ.pop("PRESERVE_DEV_DATA", None)
def test_initialize_dev_database_creates_fresh_db(tmp_path, clean_env):
"""Test dev database initialization creates clean schema"""
# Ensure PRESERVE_DEV_DATA is false for this test
os.environ["PRESERVE_DEV_DATA"] = "false"
db_path = str(tmp_path / "test_dev.db")
# Create initial database with some data
from api.database import get_db_connection, initialize_database
initialize_database(db_path)
conn = get_db_connection(db_path)
conn.execute("INSERT INTO jobs (job_id, config_path, status, date_range, models, created_at) VALUES (?, ?, ?, ?, ?, ?)",
("test-job", "config.json", "completed", "2025-01-01:2025-01-31", '["model1"]', "2025-01-01T00:00:00"))
conn.commit()
conn.close()
# Verify data exists
conn = get_db_connection(db_path)
cursor = conn.cursor()
cursor.execute("SELECT COUNT(*) FROM jobs")
assert cursor.fetchone()[0] == 1
conn.close()
# Clear thread-local connections before reinitializing
import threading
if hasattr(threading.current_thread(), '_db_connections'):
delattr(threading.current_thread(), '_db_connections')
# Initialize dev database (should reset)
initialize_dev_database(db_path)
# Verify data is cleared
conn = get_db_connection(db_path)
cursor = conn.cursor()
cursor.execute("SELECT COUNT(*) FROM jobs")
assert cursor.fetchone()[0] == 0
conn.close()
def test_cleanup_dev_database_removes_files(tmp_path):
"""Test dev cleanup removes database and data files"""
# Setup dev files
db_path = str(tmp_path / "test_dev.db")
data_path = str(tmp_path / "dev_agent_data")
Path(db_path).touch()
Path(data_path).mkdir(parents=True, exist_ok=True)
(Path(data_path) / "test_file.jsonl").touch()
# Verify files exist
assert Path(db_path).exists()
assert Path(data_path).exists()
# Cleanup
cleanup_dev_database(db_path, data_path)
# Verify files removed
assert not Path(db_path).exists()
assert not Path(data_path).exists()
def test_initialize_dev_respects_preserve_flag(tmp_path, clean_env):
"""Test that PRESERVE_DEV_DATA flag prevents cleanup"""
os.environ["PRESERVE_DEV_DATA"] = "true"
db_path = str(tmp_path / "test_dev.db")
# Create database with data
from api.database import get_db_connection, initialize_database
initialize_database(db_path)
conn = get_db_connection(db_path)
conn.execute("INSERT INTO jobs (job_id, config_path, status, date_range, models, created_at) VALUES (?, ?, ?, ?, ?, ?)",
("test-job", "config.json", "completed", "2025-01-01:2025-01-31", '["model1"]', "2025-01-01T00:00:00"))
conn.commit()
conn.close()
# Initialize with preserve flag
initialize_dev_database(db_path)
# Verify data is preserved
conn = get_db_connection(db_path)
cursor = conn.cursor()
cursor.execute("SELECT COUNT(*) FROM jobs")
assert cursor.fetchone()[0] == 1
conn.close()
def test_get_db_connection_resolves_dev_path():
"""Test that get_db_connection uses dev path in DEV mode"""
import os
os.environ["DEPLOYMENT_MODE"] = "DEV"
# This should automatically resolve to dev database
# We're just testing the path logic, not actually creating DB
from api.database import resolve_db_path
prod_path = "data/trading.db"
dev_path = resolve_db_path(prod_path)
assert dev_path == "data/trading_dev.db"
os.environ["DEPLOYMENT_MODE"] = "PROD"