Compare commits

..

3 Commits

Author SHA1 Message Date
462de3adeb fix: extract tool messages before checking FINISH_SIGNAL
**Critical Bug:**
When agent returns FINISH_SIGNAL, the code breaks immediately (line 640)
BEFORE extracting tool messages (lines 642-650). This caused tool messages
to never be captured when agent completes in single step.

**Timeline:**
1. Agent calls buy tools (MSFT, AMZN, NVDA)
2. Agent returns response with <FINISH_SIGNAL>
3. Code detects signal → break (line 640)
4. Lines 642-650 NEVER EXECUTE
5. Tool messages not captured → summarizer sees 0 tools

**Evidence from logs:**
- Console: 'Bought NVDA 10 shares'
- API: 3 trades executed (MSFT 5, AMZN 15, NVDA 10)
- Debug: 'Tool messages: 0' 

**Fix:**
Move tool extraction BEFORE stop signal check.
Agent can call tools AND return FINISH_SIGNAL in same response,
so we must process tools first.

**Impact:**
Now tool messages will be captured even when agent finishes in
single step. Summarizer will see actual trades executed.

This is the true root cause of empty tool messages in conversation_history.
2025-11-05 00:57:22 -05:00
31e346ecbb debug: add logging to verify conversation history capture
Added debug output to confirm:
- How many messages are in conversation_history
- How many assistant vs tool messages
- Preview of first assistant message content
- What the summarizer receives

This will verify that the full detailed reasoning (like portfolio
analysis, trade execution details) is being captured and passed
to the summarizer.

Output will show:
[DEBUG] Generating summary from N messages
[DEBUG] Assistant messages: X, Tool messages: Y
[DEBUG] First assistant message preview: ...
[DEBUG ReasoningSummarizer] Formatting N messages
[DEBUG ReasoningSummarizer] Breakdown: X assistant, Y tool
2025-11-05 00:46:30 -05:00
abb9cd0726 fix: capture tool messages in conversation history for summarizer
**Root Cause:**
The summarizer was not receiving tool execution results (buy/sell trades)
because they were never captured to conversation_history.

**What was captured:**
- User: 'Please analyze positions'
- Assistant: 'I will buy/sell...'
- Assistant: 'Done <FINISH_SIGNAL>'

**What was MISSING:**
- Tool: buy 14 NVDA at $185.24
- Tool: sell 1 GOOGL at $245.15

**Changes:**
- Added tool message capture in trading loop (line 649)
- Extract tool_name and tool_content from each tool message
- Capture to conversation_history before processing
- Changed message['tool_name'] to message['name'] for consistency

**Impact:**
Now the summarizer sees the actual tool results, not just the AI's
intentions. Combined with alpha.8's prompt improvements, summaries
will accurately reflect executed trades.

Fixes reasoning summaries that contradicted actual trades.
2025-11-05 00:44:24 -05:00
2 changed files with 30 additions and 8 deletions

View File

@@ -419,7 +419,7 @@ class BaseAgent:
}
if tool_name:
message["tool_name"] = tool_name
message["name"] = tool_name # Use "name" not "tool_name" for consistency with summarizer
if tool_input:
message["tool_input"] = tool_input
@@ -633,21 +633,28 @@ Summary:"""
# Capture assistant response
self._capture_message("assistant", agent_response)
# Check stop signal
if STOP_SIGNAL in agent_response:
print("✅ Received stop signal, trading session ended")
print(agent_response)
break
# Extract tool messages and count trade actions
# Extract tool messages BEFORE checking stop signal
# (agent may call tools AND return FINISH_SIGNAL in same response)
tool_msgs = extract_tool_messages(response)
print(f"[DEBUG] Extracted {len(tool_msgs)} tool messages from response")
for tool_msg in tool_msgs:
tool_name = getattr(tool_msg, 'name', None) or tool_msg.get('name') if isinstance(tool_msg, dict) else None
tool_content = getattr(tool_msg, 'content', '') or tool_msg.get('content', '') if isinstance(tool_msg, dict) else str(tool_msg)
# Capture tool message to conversation history
self._capture_message("tool", tool_content, tool_name=tool_name)
if tool_name in ['buy', 'sell']:
action_count += 1
tool_response = '\n'.join([msg.content for msg in tool_msgs])
# Check stop signal AFTER processing tools
if STOP_SIGNAL in agent_response:
print("✅ Received stop signal, trading session ended")
print(agent_response)
break
# Prepare new messages
new_messages = [
{"role": "assistant", "content": agent_response},
@@ -665,6 +672,15 @@ Summary:"""
session_duration = time.time() - session_start
# 7. Generate reasoning summary
# Debug: Log conversation history size
print(f"\n[DEBUG] Generating summary from {len(self.conversation_history)} messages")
assistant_msgs = [m for m in self.conversation_history if m.get('role') == 'assistant']
tool_msgs = [m for m in self.conversation_history if m.get('role') == 'tool']
print(f"[DEBUG] Assistant messages: {len(assistant_msgs)}, Tool messages: {len(tool_msgs)}")
if assistant_msgs:
first_assistant = assistant_msgs[0]
print(f"[DEBUG] First assistant message preview: {first_assistant.get('content', '')[:200]}...")
summarizer = ReasoningSummarizer(model=self.model)
summary = await summarizer.generate_summary(self.conversation_history)

View File

@@ -71,6 +71,12 @@ Provide a concise summary that includes the actual trades executed:"""
Returns:
Formatted text representation with emphasis on trades
"""
# Debug: Log what we're formatting
print(f"[DEBUG ReasoningSummarizer] Formatting {len(reasoning_log)} messages")
assistant_count = sum(1 for m in reasoning_log if m.get('role') == 'assistant')
tool_count = sum(1 for m in reasoning_log if m.get('role') == 'tool')
print(f"[DEBUG ReasoningSummarizer] Breakdown: {assistant_count} assistant, {tool_count} tool")
formatted_parts = []
trades_executed = []