Public/monero-gui
1
0
Fork 1
mirror of https://github.com/monero-project/monero-gui.git synced 2026-04-17 04:57:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Subaddress: fix use-after-free on accessing stale Wallet API data

Browse Source
This commit is contained in:
xiphon
2019-12-17 21:49:58 +00:00
parent 46227bdad0
commit 8c511722e0
3 changed files with 39 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libwalletqt/Subaddress.h
View File

@@ -30,6 +30,7 @@
#define SUBADDRESS_H
#include <wallet/api/wallet2_api.h>
#include <QReadWriteLock>
#include <QObject>
#include <QList>
#include <QDateTime>
@@ -38,8 +39,8 @@ class Subaddress : public QObject
{
Q_OBJECT
public:
Q_INVOKABLE QList<Monero::SubaddressRow*> getAll(bool update = false) const;
Q_INVOKABLE Monero::SubaddressRow * getRow(int index) const;
Q_INVOKABLE void getAll() const;
Q_INVOKABLE bool getRow(int index, std::function<void (Monero::SubaddressRow &row)> callback) const;
Q_INVOKABLE void addRow(quint32 accountIndex, const QString &label) const;
Q_INVOKABLE void setLabel(quint32 accountIndex, quint32 addressIndex, const QString &label) const;
Q_INVOKABLE void refresh(quint32 accountIndex) const;
@@ -54,6 +55,7 @@ public slots:
private:
explicit Subaddress(Monero::Subaddress * subaddressImpl, QObject *parent);
friend class Wallet;
mutable QReadWriteLock m_lock;
Monero::Subaddress * m_subaddressImpl;
mutable QList<Monero::SubaddressRow*> m_rows;
};