Add automatic word count and link validation to create_note, update_note, and update_sections operations to provide immediate feedback on note content quality and link integrity. Features: - Word counting excludes frontmatter and Obsidian comments, includes all other content (code blocks, inline code, headings, lists, etc.) - Link validation checks wikilinks, heading links, and embeds - Results categorized as: valid links, broken notes (note doesn't exist), and broken headings (note exists but heading missing) - Detailed broken link info includes line number and context snippet - Human-readable summary (e.g., "15 links: 12 valid, 2 broken notes, 1 broken heading") - Opt-out capability via validateLinks parameter (default: true) for performance-critical operations Implementation: - New ContentUtils.countWords() for word counting logic - Enhanced LinkUtils.validateLinks() for comprehensive link validation - Updated create_note, update_note, update_sections to return wordCount and linkValidation fields - Updated MCP tool descriptions to document new features and parameters - update_note now returns structured JSON instead of simple success message Response format changes: - create_note: added wordCount and linkValidation fields - update_note: changed to structured response with wordCount and linkValidation - update_sections: added wordCount and linkValidation fields Breaking changes: - update_note response format changed from simple message to structured JSON
Tests
This directory contains unit and integration tests for the Obsidian MCP Server plugin.
Current Status
The test files are currently documentation of expected behavior. To actually run these tests, you need to set up a testing framework.
Setting Up Jest (Recommended)
- Install Jest and related dependencies:
npm install --save-dev jest @types/jest ts-jest
- Create a
jest.config.jsfile in the project root:
module.exports = {
preset: 'ts-jest',
testEnvironment: 'node',
roots: ['<rootDir>/tests'],
testMatch: ['**/*.test.ts'],
moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json', 'node'],
collectCoverageFrom: [
'src/**/*.ts',
'!src/**/*.d.ts',
],
};
- Add test script to
package.json:
{
"scripts": {
"test": "jest",
"test:watch": "jest --watch",
"test:coverage": "jest --coverage"
}
}
- Run tests:
npm test
Test Files
path-utils.test.ts
Tests for the PathUtils class, covering:
- Path normalization (cross-platform)
- Path validation
- File/folder resolution
- Path manipulation utilities
Key Test Categories:
- normalizePath: Tests for handling leading/trailing slashes, backslashes, drive letters
- isValidVaultPath: Tests for path validation rules
- Cross-platform: Tests for Windows, macOS, and Linux path handling
Mocking Obsidian API
Since these tests run outside of Obsidian, you'll need to mock the Obsidian API:
// Example mock setup
jest.mock('obsidian', () => ({
App: jest.fn(),
TFile: jest.fn(),
TFolder: jest.fn(),
TAbstractFile: jest.fn(),
// ... other Obsidian types
}));
Running Tests Without Jest
If you prefer not to set up Jest, you can:
- Use the test files as documentation of expected behavior
- Manually test the functionality through the MCP server
- Use TypeScript's type checking to catch errors:
npm run build
Future Improvements
- Set up Jest testing framework
- Add integration tests with mock Obsidian vault
- Add tests for error-messages.ts
- Add tests for tool implementations
- Add tests for MCP server endpoints
- Set up CI/CD with automated testing
- Add code coverage reporting
Test Coverage Goals
- PathUtils: 100% coverage (critical for cross-platform support)
- ErrorMessages: 100% coverage (important for user experience)
- Tool implementations: 80%+ coverage
- Server/middleware: 70%+ coverage
Writing New Tests
When adding new features, please:
- Write tests first (TDD approach recommended)
- Test both success and error cases
- Test edge cases and boundary conditions
- Test cross-platform compatibility where relevant
- Add descriptive test names that explain the expected behavior
Example test structure:
describe('FeatureName', () => {
describe('methodName', () => {
test('should handle normal case', () => {
// Arrange
const input = 'test';
// Act
const result = method(input);
// Assert
expect(result).toBe('expected');
});
test('should handle error case', () => {
expect(() => method(null)).toThrow();
});
});
});