Bill
c62e256331
This commit resolves all required and optional issues from the plugin
submission review to comply with Obsidian plugin guidelines.
Required Changes:
- Type Safety: Added eslint-disable comments with justifications for
necessary any types in JSON-RPC tool argument handling
- Command IDs: Removed redundant "mcp-server" prefix from command
identifiers (BREAKING CHANGE):
- start-mcp-server → start-server
- stop-mcp-server → stop-server
- restart-mcp-server → restart-server
- Promise Handling: Added void operator for intentional fire-and-forget
promise in notification queue processing
- ESLint Directives: Added descriptive explanations to all
eslint-disable comments
- Switch Statement Scope: Wrapped case blocks in braces to fix lexical
declaration warnings in glob pattern matcher
- Regular Expression: Added eslint-disable comment for control character
validation in Windows path checking
- Type Definitions: Changed empty object type {} to object in MCP
capabilities interface
- Import Statements: Added comprehensive justifications for require()
usage in Electron/Node.js modules (synchronous access required)
Optional Improvements:
- Code Cleanup: Removed unused imports (MCPPluginSettings, TFile,
VaultInfo)
Documentation:
- Enhanced inline code documentation for ESLint suppressions and
require() statements
- Added detailed rationale for synchronous module loading requirements
in Obsidian plugin context
- Updated CHANGELOG.md for version 1.1.2
All changes verified:
- Build: Successful with no TypeScript errors
- Tests: All 760 tests passing
- ESLint: All review-required issues resolved
Version bumped to 1.1.2 in package.json and manifest.json
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
47 lines
1.1 KiB
JSON
47 lines
1.1 KiB
JSON
{
|
|
"name": "mcp-server",
|
|
"version": "1.1.2",
|
|
"description": "MCP (Model Context Protocol) server plugin - exposes vault operations via HTTP",
|
|
"main": "main.js",
|
|
"scripts": {
|
|
"dev": "node esbuild.config.mjs",
|
|
"build": "tsc -noEmit -skipLibCheck && node esbuild.config.mjs production",
|
|
"test": "jest",
|
|
"test:watch": "jest --watch",
|
|
"test:coverage": "jest --coverage",
|
|
"version": "node version-bump.mjs && git add manifest.json versions.json"
|
|
},
|
|
"keywords": [
|
|
"obsidian",
|
|
"mcp",
|
|
"model-context-protocol",
|
|
"ai",
|
|
"llm"
|
|
],
|
|
"author": "William Ballou",
|
|
"license": "MIT",
|
|
"dependencies": {
|
|
"cors": "^2.8.5",
|
|
"express": "^4.18.2"
|
|
},
|
|
"devDependencies": {
|
|
"@types/body-parser": "^1.19.6",
|
|
"@types/cors": "^2.8.17",
|
|
"@types/express": "^4.17.21",
|
|
"@types/jest": "^30.0.0",
|
|
"@types/node": "^16.11.6",
|
|
"@types/supertest": "^6.0.3",
|
|
"@typescript-eslint/eslint-plugin": "5.29.0",
|
|
"@typescript-eslint/parser": "5.29.0",
|
|
"builtin-modules": "3.3.0",
|
|
"electron": "^38.4.0",
|
|
"esbuild": "0.17.3",
|
|
"jest": "^30.2.0",
|
|
"obsidian": "latest",
|
|
"supertest": "^7.1.4",
|
|
"ts-jest": "^29.4.5",
|
|
"tslib": "2.4.0",
|
|
"typescript": "4.7.4"
|
|
}
|
|
}
|