Bill/monero-gui
1
0
Fork 0
forked from Public/monero-gui
Code Pull Requests Actions Packages Activity

AddressBook: thread-safety, fix use-after-free

Browse Source
This commit is contained in:
xiphon
2020-02-01 14:21:33 +00:00
parent 6de8547047
commit 742a4659f4
3 changed files with 71 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/libwalletqt/AddressBook.h
View File

@@ -31,6 +31,7 @@
#include <wallet/api/wallet2_api.h>
#include <QObject>
#include <QReadWriteLock>
#include <QList>
#include <QDateTime>
@@ -43,10 +44,9 @@ class AddressBook : public QObject
{
Q_OBJECT
public:
Q_INVOKABLE QList<Monero::AddressBookRow*> getAll(bool update = false) const;
Q_INVOKABLE Monero::AddressBookRow * getRow(int index) const;
Q_INVOKABLE bool addRow(const QString &address, const QString &payment_id, const QString &description) const;
Q_INVOKABLE bool deleteRow(int rowId) const;
Q_INVOKABLE bool getRow(int index, std::function<void (Monero::AddressBookRow &)> callback) const;
Q_INVOKABLE bool addRow(const QString &address, const QString &payment_id, const QString &description);
Q_INVOKABLE bool deleteRow(int rowId);
quint64 count() const;
Q_INVOKABLE QString errorString() const;
Q_INVOKABLE int errorCode() const;
@@ -61,6 +61,8 @@ public:
Q_ENUM(ErrorCode);
private:
void getAll();
signals:
void refreshStarted() const;
@@ -73,6 +75,7 @@ private:
explicit AddressBook(Monero::AddressBook * abImpl, QObject *parent);
friend class Wallet;
Monero::AddressBook * m_addressBookImpl;
mutable QReadWriteLock m_lock;
mutable QList<Monero::AddressBookRow*> m_rows;
};