mirror of
https://github.com/Xe138/AI-Trader.git
synced 2026-04-01 17:17:24 -04:00
Bill
14cf88f642
Major improvements: - Fixed all 42 broken tests (database connection leaks) - Added db_connection() context manager for proper cleanup - Created comprehensive test suites for undertested modules New test coverage: - tools/general_tools.py: 26 tests (97% coverage) - tools/price_tools.py: 11 tests (validates NASDAQ symbols, date handling) - api/price_data_manager.py: 12 tests (85% coverage) - api/routes/results_v2.py: 3 tests (98% coverage) - agent/reasoning_summarizer.py: 2 tests (87% coverage) - api/routes/period_metrics.py: 2 edge case tests (100% coverage) - agent/mock_provider: 1 test (100% coverage) Database fixes: - Added db_connection() context manager to prevent leaks - Updated 16+ test files to use context managers - Fixed drop_all_tables() to match new schema - Added CHECK constraint for action_type - Added ON DELETE CASCADE to trading_days foreign key Test improvements: - Updated SQL INSERT statements with all required fields - Fixed date parameter handling in API integration tests - Added edge case tests for validation functions - Fixed import errors across test suite Results: - Total coverage: 84.81% (was 61%) - Tests passing: 406 (was 364 with 42 failures) - Total lines covered: 6364 of 7504 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
96 lines
2.7 KiB
Python
96 lines
2.7 KiB
Python
"""Tests for BaseAgent conversation history tracking."""
|
|
|
|
import pytest
|
|
from agent.base_agent.base_agent import BaseAgent
|
|
|
|
|
|
def test_conversation_history_initialized_empty():
|
|
"""Conversation history should start empty."""
|
|
agent = BaseAgent(
|
|
signature="test-agent",
|
|
basemodel="test-model"
|
|
)
|
|
assert agent.conversation_history == []
|
|
assert agent.get_conversation_history() == []
|
|
|
|
|
|
def test_capture_message_user():
|
|
"""Should capture user message."""
|
|
agent = BaseAgent(
|
|
signature="test-agent",
|
|
basemodel="test-model"
|
|
)
|
|
agent._capture_message("user", "Test prompt")
|
|
|
|
history = agent.get_conversation_history()
|
|
assert len(history) == 1
|
|
assert history[0]["role"] == "user"
|
|
assert history[0]["content"] == "Test prompt"
|
|
assert "timestamp" in history[0]
|
|
|
|
|
|
def test_capture_message_assistant():
|
|
"""Should capture assistant message."""
|
|
agent = BaseAgent(
|
|
signature="test-agent",
|
|
basemodel="test-model"
|
|
)
|
|
agent._capture_message("assistant", "Test response")
|
|
|
|
history = agent.get_conversation_history()
|
|
assert len(history) == 1
|
|
assert history[0]["role"] == "assistant"
|
|
assert history[0]["content"] == "Test response"
|
|
|
|
|
|
def test_capture_message_tool():
|
|
"""Should capture tool message with tool info."""
|
|
agent = BaseAgent(
|
|
signature="test-agent",
|
|
basemodel="test-model"
|
|
)
|
|
agent._capture_message(
|
|
"tool",
|
|
"Tool result",
|
|
tool_name="get_price",
|
|
tool_input='{"symbol": "AAPL"}'
|
|
)
|
|
|
|
history = agent.get_conversation_history()
|
|
assert len(history) == 1
|
|
assert history[0]["role"] == "tool"
|
|
assert history[0]["name"] == "get_price" # Implementation uses "name" not "tool_name"
|
|
assert history[0]["tool_input"] == '{"symbol": "AAPL"}'
|
|
|
|
|
|
def test_clear_conversation_history():
|
|
"""Should clear conversation history."""
|
|
agent = BaseAgent(
|
|
signature="test-agent",
|
|
basemodel="test-model"
|
|
)
|
|
agent._capture_message("user", "Test")
|
|
assert len(agent.get_conversation_history()) == 1
|
|
|
|
agent.clear_conversation_history()
|
|
assert len(agent.get_conversation_history()) == 0
|
|
|
|
|
|
def test_get_conversation_history_returns_copy():
|
|
"""Should return a copy to prevent external modification."""
|
|
agent = BaseAgent(
|
|
signature="test-agent",
|
|
basemodel="test-model"
|
|
)
|
|
agent._capture_message("user", "Test")
|
|
|
|
history1 = agent.get_conversation_history()
|
|
history2 = agent.get_conversation_history()
|
|
|
|
# Modify one copy
|
|
history1.append({"role": "user", "content": "Extra"})
|
|
|
|
# Other copy should be unaffected
|
|
assert len(history2) == 1
|
|
assert len(agent.conversation_history) == 1
|