From c17b3db29dda781073c1ff8f6b3e81f545f899df Mon Sep 17 00:00:00 2001
From: Bill <bill@bballou.com>
Date: Fri, 31 Oct 2025 14:28:43 -0400
Subject: [PATCH] feat: implement conditional Docker tagging for pre-releases

Updates the docker-release.yml workflow to distinguish between
stable releases and pre-releases (alpha, beta, rc versions).

Changes:
- Add pre-release detection logic to extract version step
- Create new "Generate Docker tags" step to conditionally build tag list
- Only apply 'latest' tag for stable releases
- Pre-releases are tagged with version number only
- Update "Image published" message to reflect pre-release status

Example behavior:
- v0.3.0 -> tags: 0.3.0, latest
- v0.3.0-alpha -> tags: 0.3.0-alpha (NOT latest)
- v1.0.0-rc1 -> tags: 1.0.0-rc1 (NOT latest)

This prevents pre-release versions from overwriting the stable
'latest' tag, allowing users to safely pull the latest stable
version while still providing access to pre-release versions by
explicit version tag.
---
 .github/workflows/docker-release.yml | 44 +++++++++++++++++++++++++---
 1 file changed, 40 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml
index d32e247..f52c256 100644
--- a/.github/workflows/docker-release.yml
+++ b/.github/workflows/docker-release.yml
@@ -45,14 +45,45 @@ jobs:
           echo "repo_owner_lower=$REPO_OWNER_LOWER" >> $GITHUB_OUTPUT
           echo "Repository owner (lowercase): $REPO_OWNER_LOWER"
 
+          # Check if this is a pre-release (alpha, beta, rc)
+          # Only stable releases get the 'latest' tag
+          if [[ "$VERSION" == *"-alpha"* ]] || [[ "$VERSION" == *"-beta"* ]] || [[ "$VERSION" == *"-rc"* ]]; then
+            echo "is_prerelease=true" >> $GITHUB_OUTPUT
+            echo "This is a pre-release version - will NOT tag as 'latest'"
+          else
+            echo "is_prerelease=false" >> $GITHUB_OUTPUT
+            echo "This is a stable release - will tag as 'latest'"
+          fi
+
+      - name: Generate Docker tags
+        id: docker_tags
+        run: |
+          VERSION="${{ steps.meta.outputs.version }}"
+          REPO_OWNER_LOWER="${{ steps.meta.outputs.repo_owner_lower }}"
+          IS_PRERELEASE="${{ steps.meta.outputs.is_prerelease }}"
+
+          # Always tag with version
+          TAGS="ghcr.io/$REPO_OWNER_LOWER/ai-trader:$VERSION"
+
+          # Only add 'latest' tag for stable releases
+          if [[ "$IS_PRERELEASE" == "false" ]]; then
+            TAGS="$TAGS
+ghcr.io/$REPO_OWNER_LOWER/ai-trader:latest"
+            echo "Tagging as both $VERSION and latest"
+          else
+            echo "Pre-release detected - tagging as $VERSION only (NOT latest)"
+          fi
+
+          echo "tags<<EOF" >> $GITHUB_OUTPUT
+          echo "$TAGS" >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
+
       - name: Build and push Docker image
         uses: docker/build-push-action@v5
         with:
           context: .
           push: true
-          tags: |
-            ghcr.io/${{ steps.meta.outputs.repo_owner_lower }}/ai-trader:${{ steps.meta.outputs.version }}
-            ghcr.io/${{ steps.meta.outputs.repo_owner_lower }}/ai-trader:latest
+          tags: ${{ steps.docker_tags.outputs.tags }}
           cache-from: type=gha
           cache-to: type=gha,mode=max
 
@@ -60,7 +91,12 @@ jobs:
         run: |
           echo "✅ Docker image published successfully!"
           echo "📦 Pull with: docker pull ghcr.io/${{ steps.meta.outputs.repo_owner_lower }}/ai-trader:${{ steps.meta.outputs.version }}"
-          echo "📦 Or latest: docker pull ghcr.io/${{ steps.meta.outputs.repo_owner_lower }}/ai-trader:latest"
+
+          if [[ "${{ steps.meta.outputs.is_prerelease }}" == "false" ]]; then
+            echo "📦 Or latest: docker pull ghcr.io/${{ steps.meta.outputs.repo_owner_lower }}/ai-trader:latest"
+          else
+            echo "⚠️  Pre-release version - 'latest' tag not updated"
+          fi
 
       - name: Generate release notes
         id: release_notes