Bill/AI-Trader
1
0
Fork 0
mirror of https://github.com/Xe138/AI-Trader.git synced 2026-04-10 04:37:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: add migration logic for warnings column and update tests

Browse Source 
Critical fixes identified in code review:

1. Add warnings column migration to _migrate_schema()
   - Checks if warnings column exists in jobs table
   - Adds column via ALTER TABLE if missing
   - Ensures existing databases get new column on upgrade

2. Document CHECK constraint limitation
   - Added docstring explaining ALTER TABLE cannot add CHECK constraints
   - Notes that "downloading_data" status requires fresh DB or manual migration

3. Add comprehensive migration tests
   - test_migration_adds_warnings_column: Verifies warnings column migration
   - test_migration_adds_simulation_run_id_column: Tests existing migration
   - Both tests include cleanup to prevent cross-test contamination

4. Update test fixtures and expectations
   - Updated clean_db fixture to delete from all 9 tables
   - Fixed table count assertions (6 -> 9 tables)
   - Updated expected columns in schema tests

All 21 database tests now pass.
This commit is contained in:
Bill Ballou
2025-11-01 23:17:25 -04:00
parent 711ae5df73
commit baa44c208a
3 changed files with 158 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/conftest.py
View File

@@ -56,8 +56,11 @@ def clean_db(test_db_path):
cursor.execute("DELETE FROM reasoning_logs")
cursor.execute("DELETE FROM holdings")
cursor.execute("DELETE FROM positions")
cursor.execute("DELETE FROM simulation_runs")
cursor.execute("DELETE FROM job_details")
cursor.execute("DELETE FROM jobs")
cursor.execute("DELETE FROM price_data_coverage")
cursor.execute("DELETE FROM price_data")
conn.commit()
conn.close()