feat: migrate trade tools to write to actions table (new schema)

This commit implements Task 1 from the schema migration plan:
- Trade tools (buy/sell) now write to actions table instead of old positions table
- Added trading_day_id parameter to buy/sell functions
- Updated ContextInjector to inject trading_day_id
- Updated RuntimeConfigManager to include TRADING_DAY_ID in config
- Removed P&L calculation from trade functions (now done at trading_days level)
- Added tests verifying correct behavior with new schema

Changes:
- agent_tools/tool_trade.py: Modified _buy_impl and _sell_impl to write to actions table
- agent/context_injector.py: Added trading_day_id parameter and injection logic
- api/model_day_executor.py: Updated to read trading_day_id from runtime config
- api/runtime_manager.py: Added trading_day_id to config initialization
- tests/unit/test_trade_tools_new_schema.py: New tests for new schema compliance

All tests passing.

tests/unit/test_trade_tools_new_schema.py

@@ -0,0 +1,216 @@
+"""Test trade tools write to new schema (actions table)."""
+
+import pytest
+import sqlite3
+from agent_tools.tool_trade import _buy_impl, _sell_impl
+from api.database import Database
+from tools.deployment_config import get_db_path
+
+
+@pytest.fixture
+def test_db():
+    """Create test database with new schema."""
+    db_path = ":memory:"
+    db = Database(db_path)
+
+    # Create jobs table (prerequisite)
+    db.connection.execute("""
+        CREATE TABLE IF NOT EXISTS jobs (
+            job_id TEXT PRIMARY KEY,
+            config_path TEXT NOT NULL,
+            status TEXT NOT NULL,
+            date_range TEXT NOT NULL,
+            models TEXT NOT NULL,
+            created_at TEXT NOT NULL
+        )
+    """)
+
+    db.connection.execute("""
+        INSERT INTO jobs (job_id, config_path, status, date_range, models, created_at)
+        VALUES ('test-job-123', 'test_config.json', 'running', '2025-01-15', '["test-model"]', '2025-01-15T10:00:00Z')
+    """)
+
+    # Create trading_days record
+    trading_day_id = db.create_trading_day(
+        job_id='test-job-123',
+        model='test-model',
+        date='2025-01-15',
+        starting_cash=10000.0,
+        starting_portfolio_value=10000.0,
+        daily_profit=0.0,
+        daily_return_pct=0.0,
+        ending_cash=10000.0,
+        ending_portfolio_value=10000.0,
+        days_since_last_trading=0
+    )
+
+    db.connection.commit()
+
+    yield db, trading_day_id
+
+    db.connection.close()
+
+
+def test_buy_writes_to_actions_table(test_db, monkeypatch):
+    """Test buy() writes action record to actions table."""
+    db, trading_day_id = test_db
+
+    # Create a mock connection wrapper that doesn't actually close
+    class MockConnection:
+        def __init__(self, real_conn):
+            self.real_conn = real_conn
+
+        def cursor(self):
+            return self.real_conn.cursor()
+
+        def execute(self, *args, **kwargs):
+            return self.real_conn.execute(*args, **kwargs)
+
+        def commit(self):
+            return self.real_conn.commit()
+
+        def rollback(self):
+            return self.real_conn.rollback()
+
+        def close(self):
+            pass  # Don't actually close the connection
+
+    mock_conn = MockConnection(db.connection)
+
+    # Mock get_db_connection to return our mock connection
+    monkeypatch.setattr('agent_tools.tool_trade.get_db_connection',
+                       lambda x: mock_conn)
+
+    # Mock get_current_position_from_db to return starting position
+    monkeypatch.setattr('agent_tools.tool_trade.get_current_position_from_db',
+                       lambda job_id, sig, date: ({'CASH': 10000.0}, 0))
+
+    # Mock runtime config
+    monkeypatch.setenv('RUNTIME_ENV_PATH', '/tmp/test_runtime.json')
+
+    # Create mock runtime config file
+    import json
+    with open('/tmp/test_runtime.json', 'w') as f:
+        json.dump({
+            'TODAY_DATE': '2025-01-15',
+            'SIGNATURE': 'test-model',
+            'JOB_ID': 'test-job-123',
+            'TRADING_DAY_ID': trading_day_id
+        }, f)
+
+    # Mock price data
+    monkeypatch.setattr('agent_tools.tool_trade.get_open_prices',
+                       lambda date, symbols: {'AAPL_price': 150.0})
+
+    # Execute buy
+    result = _buy_impl(
+        symbol='AAPL',
+        amount=10,
+        signature='test-model',
+        today_date='2025-01-15',
+        job_id='test-job-123',
+        trading_day_id=trading_day_id
+    )
+
+    # Check if there was an error
+    if 'error' in result:
+        print(f"Buy failed with error: {result}")
+
+    # Verify action record created
+    cursor = db.connection.execute("""
+        SELECT action_type, symbol, quantity, price, trading_day_id
+        FROM actions
+        WHERE trading_day_id = ?
+    """, (trading_day_id,))
+
+    row = cursor.fetchone()
+    assert row is not None, "Action record should exist"
+    assert row[0] == 'buy'
+    assert row[1] == 'AAPL'
+    assert row[2] == 10
+    assert row[3] == 150.0
+    assert row[4] == trading_day_id
+
+    # Verify NO write to old positions table
+    cursor = db.connection.execute("""
+        SELECT name FROM sqlite_master
+        WHERE type='table' AND name='positions'
+    """)
+    assert cursor.fetchone() is None, "Old positions table should not exist"
+
+
+def test_sell_writes_to_actions_table(test_db, monkeypatch):
+    """Test sell() writes action record to actions table."""
+    db, trading_day_id = test_db
+
+    # Setup: Create starting holdings
+    db.create_holding(trading_day_id, 'AAPL', 10)
+    db.connection.commit()
+
+    # Create a mock connection wrapper that doesn't actually close
+    class MockConnection:
+        def __init__(self, real_conn):
+            self.real_conn = real_conn
+
+        def cursor(self):
+            return self.real_conn.cursor()
+
+        def execute(self, *args, **kwargs):
+            return self.real_conn.execute(*args, **kwargs)
+
+        def commit(self):
+            return self.real_conn.commit()
+
+        def rollback(self):
+            return self.real_conn.rollback()
+
+        def close(self):
+            pass  # Don't actually close the connection
+
+    mock_conn = MockConnection(db.connection)
+
+    # Mock dependencies
+    monkeypatch.setattr('agent_tools.tool_trade.get_db_connection',
+                       lambda x: mock_conn)
+
+    # Mock get_current_position_from_db to return position with AAPL shares
+    monkeypatch.setattr('agent_tools.tool_trade.get_current_position_from_db',
+                       lambda job_id, sig, date: ({'CASH': 10000.0, 'AAPL': 10}, 0))
+
+    monkeypatch.setenv('RUNTIME_ENV_PATH', '/tmp/test_runtime.json')
+
+    import json
+    with open('/tmp/test_runtime.json', 'w') as f:
+        json.dump({
+            'TODAY_DATE': '2025-01-15',
+            'SIGNATURE': 'test-model',
+            'JOB_ID': 'test-job-123',
+            'TRADING_DAY_ID': trading_day_id
+        }, f)
+
+    monkeypatch.setattr('agent_tools.tool_trade.get_open_prices',
+                       lambda date, symbols: {'AAPL_price': 160.0})
+
+    # Execute sell
+    result = _sell_impl(
+        symbol='AAPL',
+        amount=5,
+        signature='test-model',
+        today_date='2025-01-15',
+        job_id='test-job-123',
+        trading_day_id=trading_day_id
+    )
+
+    # Verify action record created
+    cursor = db.connection.execute("""
+        SELECT action_type, symbol, quantity, price
+        FROM actions
+        WHERE trading_day_id = ? AND action_type = 'sell'
+    """, (trading_day_id,))
+
+    row = cursor.fetchone()
+    assert row is not None
+    assert row[0] == 'sell'
+    assert row[1] == 'AAPL'
+    assert row[2] == 5
+    assert row[3] == 160.0